Updated FavoritesMenu to use new URL structure
- Favorites now navigate using new path-based URLs: /version/:version/:book/:chapter - Removed old setSelectedVersion state switching in favor of direct URL navigation - Added fallback to 'esv' version for older favorites without version data - Favorites display version in parentheses: 'Genesis (ESV)' - Works with all favorite types: books, chapters, and verses
This commit is contained in:
@@ -72,22 +72,18 @@ const FavoritesMenu: React.FC<FavoritesMenuProps> = ({ user, formatBookName, get
|
|||||||
|
|
||||||
const navigateToFavorite = (favorite: Favorite) => {
|
const navigateToFavorite = (favorite: Favorite) => {
|
||||||
const urlBookName = getBookUrlName(favorite.book);
|
const urlBookName = getBookUrlName(favorite.book);
|
||||||
|
const versionPath = favorite.version || 'esv'; // Default to ESV if no version
|
||||||
// Switch to the version the favorite was stored with
|
|
||||||
if (favorite.version && favorite.version !== 'esv' && setSelectedVersion) {
|
|
||||||
setSelectedVersion(favorite.version);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (favorite.chapter) {
|
if (favorite.chapter) {
|
||||||
// Navigate to chapter, with verse hash if it's a verse favorite
|
// Navigate to chapter, with verse hash if it's a verse favorite
|
||||||
let navUrl = `/book/${urlBookName}/chapter/${favorite.chapter}`;
|
let navUrl = `/version/${versionPath}/book/${urlBookName}/chapter/${favorite.chapter}`;
|
||||||
if (favorite.verse_start) {
|
if (favorite.verse_start) {
|
||||||
navUrl += `#verse-${favorite.verse_start}`;
|
navUrl += `#verse-${favorite.verse_start}`;
|
||||||
}
|
}
|
||||||
navigate(navUrl);
|
navigate(navUrl);
|
||||||
} else {
|
} else {
|
||||||
// Navigate to book
|
// Navigate to book
|
||||||
navigate(`/book/${urlBookName}`);
|
navigate(`/version/${versionPath}/book/${urlBookName}`);
|
||||||
}
|
}
|
||||||
setIsOpen(false);
|
setIsOpen(false);
|
||||||
};
|
};
|
||||||
|
|||||||
Reference in New Issue
Block a user