Files
the-bible/frontend/src/components/ChapterSelector.tsx
Ryderjj89 537898b4d0 Fixed chapter counting and numbering issues
- Updated API functions to accept version parameter (getBook, getChapter)
- Added proper chapter sorting with parseInt for numerical order
- Removed fallback to 50 fake chapters - now shows actual chapter counts
- Fixed Psalms chapter numbering: 1,2,3,4,5,6,7,8,9,10,11,12... instead of 1,2,3,4,5,6,7,8,9,10,101,102...
- Books like 2 John now show correct number of chapters (1) instead of fake 50
2025-09-28 17:58:47 -04:00

237 lines
8.2 KiB
TypeScript

import React, { useState, useEffect } from 'react';
import { ArrowLeft, FileText, Star, ChevronRight, Search } from 'lucide-react';
import { getBook } from '../services/api';
interface ChapterSelectorProps {
book: string;
onChapterSelect: (chapter: string) => void;
onBack: () => void;
formatBookName: (bookName: string) => string;
user?: any;
onFavoriteChange?: () => void;
version?: string;
onSearchClick?: () => void;
}
const ChapterSelector: React.FC<ChapterSelectorProps> = ({ book, onChapterSelect, onBack, formatBookName, user, onFavoriteChange, version = 'esv', onSearchClick }) => {
const [chapters, setChapters] = useState<string[]>([]);
const [loading, setLoading] = useState(true);
const [favorites, setFavorites] = useState<Set<string>>(new Set());
useEffect(() => {
loadChapters();
}, [book]);
// Load favorites when user is available
useEffect(() => {
if (user) {
loadFavorites();
}
}, [user, book, version]);
const loadFavorites = async () => {
if (!user) return;
try {
const response = await fetch('/api/favorites', {
credentials: 'include'
});
if (response.ok) {
const data = await response.json();
const favoriteChapters: string[] = data.favorites
.filter((fav: any) => fav.book === book && fav.chapter && fav.version === version && !fav.verse_start) // Only chapter-level favorites for this book and version
.map((fav: any) => fav.chapter);
const chapterFavorites = new Set<string>(favoriteChapters);
setFavorites(chapterFavorites);
console.log('Loaded chapter favorites for version:', version, favoriteChapters);
}
} catch (error) {
console.error('Failed to load favorites:', error);
}
};
const toggleFavorite = async (chapter: string, event: React.MouseEvent) => {
event.stopPropagation(); // Prevent chapter selection when clicking star
if (!user) return;
const isFavorited = favorites.has(chapter);
try {
if (isFavorited) {
// Remove favorite
const response = await fetch('/api/favorites', {
credentials: 'include'
});
if (response.ok) {
const data = await response.json();
const chapterFavorite = data.favorites.find((fav: any) =>
fav.book === book && fav.chapter === chapter && !fav.verse_start
);
if (chapterFavorite) {
await fetch(`/api/favorites/${chapterFavorite.id}`, {
method: 'DELETE',
credentials: 'include'
});
setFavorites(prev => {
const newFavorites = new Set(prev);
newFavorites.delete(chapter);
return newFavorites;
});
onFavoriteChange?.(); // Notify parent to refresh favorites menu
}
}
} else {
// Add favorite
const response = await fetch('/api/favorites', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
},
credentials: 'include',
body: JSON.stringify({
book: book,
chapter: chapter,
version: version
})
});
if (response.ok) {
setFavorites(prev => new Set(prev).add(chapter));
onFavoriteChange?.(); // Notify parent to refresh favorites menu
}
}
} catch (error) {
console.error('Failed to toggle favorite:', error);
}
};
const loadChapters = async () => {
try {
setLoading(true);
const response = await getBook(book, version);
// The API now returns { chapters: ["1", "2", "3", ...] }
if (response.chapters) {
// Sort chapters numerically to ensure proper order
const sortedChapters = response.chapters.sort((a, b) => parseInt(a, 10) - parseInt(b, 10));
setChapters(sortedChapters);
} else {
console.error('API returned no chapters data');
setChapters([]);
}
} catch (error) {
console.error('Failed to load chapters:', error);
// Don't show fallback chapters - just show an empty list
setChapters([]);
} finally {
setLoading(false);
}
};
if (loading) {
return (
<div className="text-center py-12">
<FileText className="mx-auto h-12 w-12 text-blue-600 animate-pulse mb-4" />
<p className="text-lg text-gray-600 dark:text-gray-400">Loading chapters...</p>
</div>
);
}
return (
<div>
{/* Search Bar */}
<div className="flex justify-center mb-4">
<div className="w-full max-w-md relative">
<input
type="text"
placeholder="Search for verses, words, or phrases..."
className="w-full pl-10 pr-4 py-3 text-gray-900 dark:text-gray-100 bg-white dark:bg-gray-800 border border-gray-300 dark:border-gray-600 rounded-lg shadow-sm focus:ring-2 focus:ring-blue-500 focus:border-transparent"
onClick={onSearchClick}
readOnly
/>
<Search className="absolute left-3 top-1/2 transform -translate-y-1/2 h-5 w-5 text-gray-400" />
</div>
</div>
{/* Breadcrumb Navigation */}
<div className="flex items-center justify-center space-x-1 mb-4">
<button
onClick={() => window.location.href = `/version/${version}`}
className="flex items-center space-x-1 text-sm text-gray-600 dark:text-gray-400 hover:text-blue-600 dark:hover:text-blue-400 transition-colors"
>
<ArrowLeft className="h-4 w-4" />
<span>Books</span>
</button>
<ChevronRight className="h-3 w-3 text-gray-400 dark:text-gray-500" />
<span className="text-sm font-medium text-gray-900 dark:text-gray-100">
{formatBookName(book)}
</span>
</div>
{/* Book Title */}
<div className="text-center mb-8">
<h1 className="text-3xl font-bold text-gray-900 dark:text-gray-100 mb-2">
{formatBookName(book)}
</h1>
<p className="text-lg text-gray-600 dark:text-gray-400">
Select a chapter to read
</p>
{user && (
<p className="text-sm text-gray-500 dark:text-gray-400 mt-2">
Click the to add chapters to your favorites
</p>
)}
</div>
{/* Chapters Grid */}
<div className="grid grid-cols-4 sm:grid-cols-6 md:grid-cols-8 lg:grid-cols-10 gap-3 max-w-4xl mx-auto">
{chapters.map((chapter) => (
<div key={chapter} className="relative">
<button
onClick={() => onChapterSelect(chapter)}
className="group bg-white dark:bg-gray-800 p-4 rounded-lg shadow-sm border border-gray-200 dark:border-gray-700 hover:shadow-md hover:border-blue-300 dark:hover:border-blue-600 transition-all duration-200 text-center w-full"
>
<FileText className="mx-auto h-6 w-6 text-blue-600 dark:text-blue-400 mb-2 group-hover:scale-110 transition-transform" />
<span className="text-sm font-medium text-gray-900 dark:text-gray-100 group-hover:text-blue-600 dark:group-hover:text-blue-400">
{chapter}
</span>
</button>
{/* Star button - only show for authenticated users */}
{user && (
<button
onClick={(e) => toggleFavorite(chapter, e)}
className="absolute top-1 right-1 p-1 rounded-full hover:bg-gray-100 dark:hover:bg-gray-700 transition-colors"
title={favorites.has(chapter) ? 'Remove from favorites' : 'Add to favorites'}
>
<Star
className={`h-3 w-3 ${
favorites.has(chapter)
? 'text-yellow-500 fill-yellow-500'
: 'text-gray-400 hover:text-yellow-500'
} transition-colors`}
/>
</button>
)}
</div>
))}
</div>
{/* Chapter Count */}
<div className="text-center mt-8">
<p className="text-sm text-gray-500 dark:text-gray-400">
{chapters.length} chapters available
</p>
</div>
</div>
);
};
export default ChapterSelector;