fix: Align account lockout threshold with IP rate limiting

Fixed inconsistency between IP-based rate limiting and per-account lockout.
Previously, users would hit the IP rate limit at 5 attempts (15 min lockout)
but the account wouldn't be marked as locked until 10 attempts (30 min).
This caused confusion in the admin UI where locked accounts wouldn't show
the unlock button until 10 attempts were reached.

Changes:
- Reduced account lockout threshold from 10 to 5 failed attempts
- Reduced account lockout duration from 30 to 15 minutes
- Updated error message to reflect 15 minute lockout period
- Added detailed logging when account gets locked
- Updated README documentation to reflect correct limits

Both protection layers now work in harmony:
- IP-based rate limiting: 5 attempts = 15 min lockout
- Per-account lockout: 5 attempts = 15 min lock

This ensures the admin UI accurately shows account lock status and provides
the unlock option as soon as users hit the lockout threshold.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2025-11-05 18:32:17 -05:00
parent c7142ca6a5
commit 4aaeb0d579
3 changed files with 8 additions and 6 deletions

View File

@@ -259,8 +259,8 @@ This application implements enterprise-grade security following OWASP best pract
- Protection against session fixation attacks - Protection against session fixation attacks
5. **Account Lockout (Dual-Layer Brute Force Protection)** 5. **Account Lockout (Dual-Layer Brute Force Protection)**
- IP-based rate limiting (existing) - IP-based rate limiting: 5 failed attempts = 15 minute lockout
- Per-account lockout: 10 failed attempts = 30 minute lock - Per-account lockout: 5 failed attempts = 15 minute lock
- Automatic unlock after expiration - Automatic unlock after expiration
- Admin manual unlock capability via UI - Admin manual unlock capability via UI

View File

@@ -57,7 +57,7 @@ export default defineEventHandler(async (event) => {
console.log(`[LOGIN BLOCKED] Account locked - User: ${username.toLowerCase()}, IP: ${clientIp}`) console.log(`[LOGIN BLOCKED] Account locked - User: ${username.toLowerCase()}, IP: ${clientIp}`)
throw createError({ throw createError({
statusCode: 403, statusCode: 403,
message: 'Account temporarily locked due to too many failed login attempts. Please try again in 30 minutes or contact an administrator.' message: 'Account temporarily locked due to too many failed login attempts. Please try again in 15 minutes or contact an administrator.'
}) })
} }

View File

@@ -469,17 +469,19 @@ export function incrementFailedAttempts(username: string): void {
if (!user) return if (!user) return
const newAttempts = (user.failed_login_attempts || 0) + 1 const newAttempts = (user.failed_login_attempts || 0) + 1
const maxAttempts = 10 const maxAttempts = 5 // Aligned with IP rate limiting
if (newAttempts >= maxAttempts) { if (newAttempts >= maxAttempts) {
// Lock account for 30 minutes // Lock account for 15 minutes (aligned with IP rate limiting)
const lockUntil = new Date(Date.now() + 30 * 60 * 1000).toISOString() const lockUntil = new Date(Date.now() + 15 * 60 * 1000).toISOString()
db.prepare('UPDATE users SET failed_login_attempts = ?, locked_until = ? WHERE username = ?') db.prepare('UPDATE users SET failed_login_attempts = ?, locked_until = ? WHERE username = ?')
.run(newAttempts, lockUntil, username) .run(newAttempts, lockUntil, username)
console.log(`[ACCOUNT LOCKED] User ${username} locked after ${newAttempts} failed attempts until ${lockUntil}`)
} else { } else {
// Just increment counter // Just increment counter
db.prepare('UPDATE users SET failed_login_attempts = ? WHERE username = ?') db.prepare('UPDATE users SET failed_login_attempts = ? WHERE username = ?')
.run(newAttempts, username) .run(newAttempts, username)
console.log(`[ACCOUNT SECURITY] Failed login attempt #${newAttempts} for user: ${username}`)
} }
} }